Fixed issue #18936: User count in group is not OK after deleting a user #3306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrieljenik
commented
Jul 25, 2023
•
gabrieljenik
commented
- Moved code to a new function on a service class
- Added the "remove from groups" operation
- Avoid error when a user group owner is missing.
- Avoid several inconsitencies.
- When a user is deleted, automatically transfer their groups to main admin.
…r-deleting-a-user
…r-deleting-a-user
Shnoulle
approved these changes
Jul 26, 2023
Shnoulle
added
Code review done
tiborpacalat
added
Tested OK
tiborpacalat
deleted the
bug/18936--User-count-in-group-is-not-OK-after-deleting-a-user
branch
olleharstedt
reviewed
Aug 7, 2023
| * @param int $userId | ||
| * @return OperationResult | ||
| */ | ||
| public function deleteUser($userId) |
There was a problem hiding this comment.
- If you already have target user in the constructor, why do you need $userId here?
- Maybe target user is not good to inject as a dependency in the constructor, but rather should be a method argument? Especially if it's only used by some methods.
- I usually prefer to pass around models instead of ids to models:
public function deleteUser(User $user)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.