Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #18906: Unable to fix or edit survey with UpperCase templ… #3316

Closed
wants to merge 1 commit into from

Conversation

Shnoulle
Copy link
Collaborator

Fixed issue #18906: Unable to fix or edit survey with UpperCase template name
Dev: set to existing directory/folder

…ate name

Dev: set to existing directory/folder
@Shnoulle
Copy link
Collaborator Author

An alterantive solution are check if templatename == templete->folder

if (is_object($oTemplate) && $oTemplate->checkTemplate() && self::checkTemplateXML($oTemplate->folder) && $oTemplate->folder == $sTemplateName) {

But this one are in https://bugs.limesurvey.org/view.php?id=18907
Currently : just fix broken import.

@Shnoulle
Copy link
Collaborator Author

Here : i set uppercase to UpperCase if needed. Aletrnative solutuion uppercase reset to default template.

@ptelu ptelu closed this Jul 31, 2023
@ptelu ptelu deleted the bug./5X_18906_UppercaseTemplateImport branch July 31, 2023 09:35
@Shnoulle
Copy link
Collaborator Author

@ptelu can we know why you close this PR ?

We can discuss on te way to fix , but we NEED a fix ....

@ptelu ptelu restored the bug./5X_18906_UppercaseTemplateImport branch July 31, 2023 14:45
@ptelu ptelu reopened this Jul 31, 2023
@ptelu
Copy link
Contributor

ptelu commented Jul 31, 2023

@Shnoulle Hey this wasnt intentionally closed, the branch attached to this PR cause issue when trying to update local git environments, thats why i renamed the branch from "bug./5X_18906_UppercaseTemplateImport" to "bug/5X_18906_UppercaseTemplateImport". I restored everything now, but please update the branch as soon as you can. Both branches exist only difference is naming feel free to delete it. Try not to use "." in the names.

@Shnoulle
Copy link
Collaborator Author

Oh i add a dot after bug ?

Sorry ....

@Shnoulle
Copy link
Collaborator Author

Replaced #3319

@Shnoulle Shnoulle closed this Jul 31, 2023
@Shnoulle Shnoulle deleted the bug./5X_18906_UppercaseTemplateImport branch July 31, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants