Fixed issue 18821: Public url is not used for SURVEYURL #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrieljenik
commented
Aug 18, 2023
gabrieljenik
commented
- Test for cretaePublicUrl and getPublicBaseUrl
- Porting fix for LSYiiValidatorsTest::testXssFilterAttributeForSuperAdmin()
- Porting fix about urls
Expected url generated dinamically so that tests stick to site configuration.
This reverts commit ac0bac2.
$_SERVER attributes initialized to avoid errors.
Shnoulle
reviewed
Apr 29, 2024
Shnoulle
reviewed
Apr 29, 2024
| $parameters = array('param_one' => 1, 'param_two' => 2); | ||
| $url = Yii::app()->createPublicUrl('controller/action', $parameters); | ||
|
|
||
| $expectedRelativeUrl = Yii::app()->createUrl('controller/action', $parameters); |
|
This test is already merged on master. |
OK, i think its a new test here :) |
Shnoulle
approved these changes
May 1, 2024
Shnoulle
added
Code review done
tiborpacalat
deleted the
bug/18821-public-url-is-not-used-for-SURVEYURL-test-v5
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.