Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modules folder to the import path for the default Yii config file. #34

Merged
merged 1 commit into from Aug 16, 2012
Merged

Add modules folder to the import path for the default Yii config file. #34

merged 1 commit into from Aug 16, 2012

Conversation

aaronschmitz
Copy link
Contributor

This line needs to be in the config file for my question objects to work. Since the default is copied when 2.0 is installed, it makes sense to include this path in the original distribution of 2.0.

@ghost ghost assigned c-schmitz Aug 15, 2012
@tpartner
Copy link
Collaborator

Hmm…that’s a little cryptic. Do we need to do anything with our current local repositories?

T.

From: Aaron Schmitz [mailto:notifications@github.com]
Sent: August-15-12 10:16 AM
To: LimeSurvey/LimeSurvey
Subject: [LimeSurvey] Add modules folder to the import path for the default Yii config file. (#34)

This line needs to be in the config file for my question objects to work. Since the default is copied when 2.0 is installed, it makes sense to include this path in the original distribution of 2.0.


You can merge this Pull Request by running:

git pull https://github.com/aaronschmitz/LimeSurvey Alter_config

Or view, comment on, or merge it at:

#34

Commit Summary

  • Add modules folder to the import path for the default Yii config file.

File Changes

  • M application/config/config-sample.php (1)

Patch Links


Reply to this email directly or view it on GitHub #34 .

Description: Image removed by sender.

Email scanned by PC Tools - No viruses or spyware found.
(Email Guard: 9.0.0.1218, Virus/Spyware Database: 6.19620)

http://www.pctools.com http://www.pctools.com/?cclick=EmailFooterClean_51

@aaronschmitz
Copy link
Contributor Author

Not yet, but when I merge my code in after we release 2.0, we'll need to find a way to either automatically update the config or tell anybody who used the RC's to manually add that line.

That's why I'm proposing we add it into 2.0 now so that we only have to find a way to push the change to beta testers who do an in-place install of the stable release ... not everybody.

@tpartner
Copy link
Collaborator

Thanks for the clarification Aaron.

T.

From: Aaron Schmitz [mailto:notifications@github.com]
Sent: August-15-12 10:28 AM
To: LimeSurvey/LimeSurvey
Cc: Tony Partner
Subject: Re: [LimeSurvey] Add modules folder to the import path for the default Yii config file. (#34)

Not yet, but when I merge my code in after we release 2.0, we'll need to find a way to either automatically update the config or tell anybody who used the RC's to manually add that line.

That's why I'm proposing we add it into 2.0 now so that we only have to find a way to push the change to beta testers who do an in-place install of the stable release ... not everybody.


Reply to this email directly or view it on GitHub #34 (comment) .

Description: Image removed by sender.

Email scanned by PC Tools - No viruses or spyware found.
(Email Guard: 9.0.0.1218, Virus/Spyware Database: 6.19620)

http://www.pctools.com http://www.pctools.com/?cclick=EmailFooterClean_51

c-schmitz added a commit that referenced this pull request Aug 16, 2012
Dev Add modules folder to the import path for the default Yii config file.
@c-schmitz c-schmitz merged commit eeed1f1 into LimeSurvey:Yii Aug 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants