Fixed issue #18602: When surveys are copied without copying attachments, attachment info is copied but not updated #3430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts, attachment info is copied but not updated
Shnoulle
reviewed
Sep 8, 2023
| { | ||
| $isInSurvey = Yii::app()->is_file( | ||
| $attachment['url'], | ||
| Yii::app()->getConfig('uploaddir') . DIRECTORY_SEPARATOR . "surveys" . DIRECTORY_SEPARATOR . $surveyId, |
Shnoulle
approved these changes
Sep 8, 2023
| <?php if ($attachmentsHaveErrors): ?> | ||
| <div class="row"> | ||
| <div class='col-sm-12'> | ||
| <div class="alert alert-danger"><?= gT("There are errors with this template's attachments. Please check them below.") ?></div> |
There was a problem hiding this comment.
"There are errors with this template's attachments. Please check them below."
maybe more "There are errors with this email's attachments. Please check them below." ?
Shnoulle
added
Code review done
gabrieljenik
added
Tested OK
tiborpacalat
deleted the
bug/18602-master-Email-Template-Attachments-appear-to-carry-over-with-copied-survey--but-do-not-work
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.