Fixed issue #18494: TypeError during demo survey "ls205_em_tailoring" #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapper for abs function added.
Wrapper for ceil function added.
Expression manager test relocated and fixed.
Fixed from commit cedcf60 added.
Cases for abs function added.
Buggy code deleted.
Shnoulle
approved these changes
Sep 13, 2023
Shnoulle
added
Code review done
Duplicated abs array key deleted.
Shnoulle
approved these changes
Sep 14, 2023
tiborpacalat
added
Tested OK
tiborpacalat
deleted the
bug/18494-typeerror-during-demo-survey-ls205emtailoring
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expression manager test relocated and fixed.
Wrapper for abs function added.
Ported a fix on a test from master (cedcf60)
Reviewed ceil, floor, round, pow