Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19081: Lato fonts are loaded from Google fonts instead of solely using the ones shipped with limesurvey itself #3543

Merged

Conversation

gabrieljenik
Copy link
Collaborator

@gabrieljenik gabrieljenik commented Oct 17, 2023

Lato font url modified to load locally.

Other variations may need to be updated. Waiting on feedback before moving forward

…f solely using the ones shipped with limesurvey itself

Lato font url modified to load locally.
@Shnoulle
Copy link
Collaborator

No generator ?

@gabrieljenik
Copy link
Collaborator Author

No generator ?

When discussing it was concluded it was an overkill

@Shnoulle Shnoulle added the Code review done Version checked for code issue without testing label Oct 17, 2023
@Shnoulle
Copy link
Collaborator

Already approved

…f solely using the ones shipped with limesurvey itself

Lato font url modified in variations to load locally.
@Shnoulle
Copy link
Collaborator

import url(../../../../../assets/fonts/lato.css) with asset and without asset ? With debug=0 or 1 ?

Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question about position of the file according to debug mode or not ?

See 'use_asset_manager'

@gabrieljenik
Copy link
Collaborator Author

import url(../../../../../assets/fonts/lato.css) with asset and without asset ? With debug=0 or 1 ?

Not sure I understand the comment. Still, how do you suggest to do the import?

@gabrieljenik
Copy link
Collaborator Author

Question about position of the file according to debug mode or not ?

See 'use_asset_manager'

But here is a CSS, no PHP... Not sure I get the comment.

@Shnoulle
Copy link
Collaborator

Question about position of the file according to debug mode or not ?
See 'use_asset_manager'

But here is a CSS, no PHP... Not sure I get the comment.

If you use asset manager : themes/survey/bootswatch/ was copied to tmp/assets/[randomstring] don't know for fonts.

Difference between debug=0 and debug=2 : link are not the same in my opinion.

@Shnoulle
Copy link
Collaborator

Question about position of the file according to debug mode or not ?
See 'use_asset_manager'

But here is a CSS, no PHP... Not sure I get the comment.

asset_manager are related to CSS/script image, logo etc … any file you want in assets …

@gabrieljenik
Copy link
Collaborator Author

If you use asset manager : themes/survey/bootswatch/ was copied to tmp/assets/[randomstring] don't know for fonts.

Oh, I see.... Let me review.

…f solely using the ones shipped with limesurvey itself

Other fonts are now loaded locally.
@Shnoulle
Copy link
Collaborator

Shnoulle commented Nov 3, 2023

OK it work because themes/survey/bootswatch and tmp/assets/8aabd431 have same directory number …

But unable to do it for uploaded theme :(

Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for the purpose …

@gabrieljenik
Copy link
Collaborator Author

OK it work because themes/survey/bootswatch and tmp/assets/8aabd431 have same directory number …

Yes, there is a further explanation on mantis.

@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Nov 9, 2023
@tiborpacalat tiborpacalat merged commit 47ec655 into master Nov 9, 2023
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19081-lato-fonts-are-loaded-from-google-instead-of-ls branch November 9, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants