-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #19081: Lato fonts are loaded from Google fonts instead of solely using the ones shipped with limesurvey itself #3543
Conversation
…f solely using the ones shipped with limesurvey itself Lato font url modified to load locally.
No generator ? |
When discussing it was concluded it was an overkill |
Already approved |
…f solely using the ones shipped with limesurvey itself Lato font url modified in variations to load locally.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question about position of the file according to debug mode or not ?
Not sure I understand the comment. Still, how do you suggest to do the import? |
But here is a CSS, no PHP... Not sure I get the comment. |
If you use asset manager : themes/survey/bootswatch/ was copied to tmp/assets/[randomstring] don't know for fonts. Difference between debug=0 and debug=2 : link are not the same in my opinion. |
asset_manager are related to CSS/script image, logo etc … any file you want in assets … |
Oh, I see.... Let me review. |
…f solely using the ones shipped with limesurvey itself Other fonts are now loaded locally.
OK it work because But unable to do it for uploaded theme :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for the purpose …
Yes, there is a further explanation on mantis. |
Lato font url modified to load locally.
Other variations may need to be updated. Waiting on feedback before moving forward