Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19139: CSRF in Reset Survey menus #3598

Merged
merged 5 commits into from Nov 15, 2023

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

No CSRF validation rules set from app request.
Some tests are skipped since rest routes are not expected to skip CSRF validation.
@Shnoulle
Copy link
Collaborator

Shnoulle commented Nov 6, 2023

See #3599

@gabrieljenik
Copy link
Collaborator Author

@Shnoulle Ready for re-reviewal

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Nov 14, 2023
@Shnoulle
Copy link
Collaborator

Same than master now :)

@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Nov 15, 2023
@tiborpacalat tiborpacalat merged commit 487e073 into 5.x Nov 15, 2023
9 checks passed
@tiborpacalat tiborpacalat deleted the bug/19139--CSRF-in-Reset-Survey-menus-v5 branch November 15, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants