Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue : Unable to create survey with debug = 2 and PHP8 #3613

Merged
merged 2 commits into from Nov 10, 2023
Merged

Fixed issue : Unable to create survey with debug = 2 and PHP8 #3613

merged 2 commits into from Nov 10, 2023

Conversation

Shnoulle
Copy link
Collaborator

No description provided.

c-schmitz
c-schmitz approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@c-schmitz c-schmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine!

@Shnoulle Shnoulle added Needs testing Code review done Version checked for code issue without testing labels Nov 10, 2023
@Shnoulle Shnoulle removed the request for review from gabrieljenik November 10, 2023 14:29
@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Nov 10, 2023
@tiborpacalat tiborpacalat merged commit e9dac42 into master Nov 10, 2023
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19230_debugPHP8_xssFilter branch November 10, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-schmitz c-schmitz c-schmitz approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
3 participants
@Shnoulle @c-schmitz @tiborpacalat