New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #19262: Invalid fruity_twentythree template directory on … #3642
Fixed issue #19262: Invalid fruity_twentythree template directory on … #3642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need testing
How get multiple theme, i need to add it manually ?
A fresh install from dbversion 615 or 616 is enough, using Postgres. Then updating to 617 will clear all settings, without this fix. Again, using Postgres. |
But : i don't have multiple theme lines, then i can not control if the update fix the DB |
You don't have entries in table |
I have : but not multiple :) |
Need to test if deleteDuplicateTemplateConfigurationEntries really delete NOT used TemplateConfiguration |
Tested : seems there are an issue with the original commit … Seems it must keep the minimal id, not the max. |
Yep : confirm the issue in case of multiple theme
find get the 1st element, not the last. Else : this commit is OK in pgsql : keep one configuration only (but the bad one) |
@Shnoulle did you do both code-review and test? |
I test : but i can not do both … I have to report the issue about them option loose, but i don't know how to get it except do it in DB (and it's not related to pgsql) |
Test way and result : #3642 (comment) |
…PostgreSQL
Fixed issue #:
New feature #:
Dev: