Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #19293: Can't take survey after adding language in PHP 8.1 #3658

Merged
merged 2 commits into from Dec 12, 2023
Merged

Fixed issue #19293: Can't take survey after adding language in PHP 8.1 #3658

merged 2 commits into from Dec 12, 2023

Conversation

gabrieljenik
Copy link
Collaborator

@gabrieljenik gabrieljenik commented Dec 6, 2023 •
edited

No description provided.

Shnoulle
Shnoulle reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I clearly prefer :

if (empty($processString)) {
    return "";
}

or

if (is_null($processString)) {
    return "";
}

Else need phpdoc fix her :

LimeSurvey/application/helpers/SurveyRuntimeHelper.php

Line 1385 in 409293f

* @param string $sString the string to evaluate

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Dec 11, 2023
@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Dec 12, 2023
@tiborpacalat tiborpacalat merged commit 92a247a into master Dec 12, 2023
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19293--Can-t-take-survey-after-adding-language-in-PHP-8.1 branch December 12, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@gabrieljenik @Shnoulle @tiborpacalat @lapiudevgit