Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed url when directLogin true #3660

Merged
merged 1 commit into from Dec 11, 2023
Merged

fixed url when directLogin true #3660

merged 1 commit into from Dec 11, 2023

Conversation

mbischof
Copy link
Contributor

Fixed issue #19302: directLogin = true with wrong redirect

Shnoulle
Shnoulle approved these changes Dec 11, 2023
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Shnoulle
Copy link
Collaborator

@tiborpacalat i really think we don't need test here. The patch is clearly needed. Ping @olleharstedt

@Shnoulle Shnoulle added the Code review done Version checked for code issue without testing label Dec 11, 2023
@tiborpacalat tiborpacalat merged commit 23795ae into LimeSurvey:5.x Dec 11, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing
Projects
None yet
Milestone
No milestone
3 participants
@mbischof @Shnoulle @tiborpacalat