New feature #19299: Unmask token field #3673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev: add input-group-text to hide/show tokn Dev: add inline javascript : can be move to theme.js Dev: but maybe more understandable for updationg by other theme user (beginner and not developer)
|
It's currently a choice to leave JS in this file. Make for user who are not developer, easy to understand and to update only this part. |
|
New feature in master branch? Why not dev? |
Really ? I think dev is more for big feature (with some risk of breaking DB or something else) , not for minor feature, no ? |
|
No, all features go into dev, master is for bug fixes only. But this was small, so no problem. |
OK, remind for next time (or move feature request to ergnomy issue ;) ) |
|
Hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: add input-group-text to hide/show tokn
Dev: add inline javascript : can be move to theme.js
Dev: but maybe more understandable for updationg by other theme user (beginner and not developer)