Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19331: Try to add a subquestion to a matrix type question throws an SQL error #3686

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Jan 8, 2024
@Shnoulle
Copy link
Collaborator

Test done (on pgsql) by reporter : https://bugs.limesurvey.org/view.php?id=19332

@Shnoulle
Copy link
Collaborator

Shnoulle commented Jan 16, 2024

@gabrieljenik with php8.3

DOMAIN=lstest.local phpunit ./tests/unit/services/QuestionAggregateService/SubquestionsServiceTest.php

…
	<p class="message">
		Calling get_class() without arguments is deprecated	</p>

	<div class="source">
		<p class="file">/media/shnoulle/data/webdev/lstest/application/helpers/ClassFactory.php(39)</p>

PS :
try with self::$registered = spl_autoload_register(array(self::class, 'autoload'), true, true);

$ DOMAIN=lstest.local  phpunit ./tests/unit/services/QuestionAggregateService/SubquestionsServiceTest.php 
Set $forceDebug=false in tests/bootstrap.php to reduce the logging.
Error Reporting and Debug: Yes

PHP Fatal error:  PHPUnit\TextUI\RuntimeException cannot implement PHPUnit\TextUI\Exception - it is not an interface in /usr/share/php/PHPUnit/TextUI/Exception/RuntimeException.php on line 15

Fatal error: PHPUnit\TextUI\RuntimeException cannot implement PHPUnit\TextUI\Exception - it is not an interface in /usr/share/php/PHPUnit/TextUI/Exception/RuntimeException.php on line 15

@Shnoulle
Copy link
Collaborator

Move the error from 8.2 to 7.4 ?????? WTF ?

@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Jan 29, 2024
@tiborpacalat tiborpacalat merged commit 726fb90 into master Jan 29, 2024
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19331--Try-to-add-a-subquestion-to-a-matrix-type-question-throws-an-SQL-error branch January 29, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
4 participants