Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19344: Survey activation error using MSSQL #3696

Conversation

c-schmitz
Copy link
Contributor

@c-schmitz c-schmitz commented Jan 11, 2024

Dev Also added a new integrity check function to archive tables that are left from previous activation attempts

@c-schmitz c-schmitz changed the title Fixed issue #19344: Survey activation error when create a new survey using MSSQL Fixed issue #19344: Survey activation error using MSSQL Jan 11, 2024
@@ -324,6 +324,7 @@ protected function createResponseTable()
// Refresh schema cache just in case the table existed in the past
Yii::app()->db->schema->getTable($sTableName, true);
} catch (Exception $e) {
$this->error = 'surveytablecreation';
if (App()->getConfig('debug')) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not always add $e->getMessage(); ?

@tiborpacalat tiborpacalat merged commit 3593c6d into master Jan 16, 2024
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19344__Survey_activation_error_when_create_a_new_survey branch January 16, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants