Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #18473: Survey listing : multiple call of template #3738

Merged
merged 5 commits into from Mar 5, 2024
Merged

Fixed issue #18473: Survey listing : multiple call of template #3738

merged 5 commits into from Mar 5, 2024

Conversation

Shnoulle
Copy link
Collaborator

Dev: avoid multiple call of TemplateConfiguration::model()->search()

@Shnoulle
Fixed issue #19371: Survey list page extremely slow when having alot …
5d12b39 
…of surveys

Dev: avoid multiple call of TemplateConfiguration::model()->search()
@Shnoulle
Copy link
Collaborator Author

Clearly need a better solution here :

  1. no need to call search to have only the list of templet
  2. need only the template name from DB

@Shnoulle
Dev: better improvment for template
21e1725 
Dev: getTemplateList as static
Dev: getTemplateList ligther request
Dev: getTemplateList return only valid folders
@Shnoulle
Copy link
Collaborator Author

Ok, better fix now !

@Shnoulle Shnoulle mentioned this pull request Feb 15, 2024
Merged
lajosarpad
lajosarpad requested changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@lajosarpad lajosarpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good, we have a duplicated variable initialization though and we will need to get rid of that

application/models/Template.php Show resolved Hide resolved
@Shnoulle Shnoulle added Code review done Version checked for code issue without testing and removed Needs code review labels Feb 24, 2024
@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Mar 5, 2024
@tiborpacalat tiborpacalat merged commit bbc3eb6 into master Mar 5, 2024
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19371_partial_template branch March 5, 2024 16:21
@Shnoulle Shnoulle mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-schmitz c-schmitz c-schmitz approved these changes

@lajosarpad lajosarpad lajosarpad approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
4 participants
@Shnoulle @c-schmitz @lajosarpad @tiborpacalat