Fixed issue #CT-652: system slowness when saving survey settings

[ptelu]

No description provided.

[Shnoulle]

I dislike to use Cache for Static var … Static is not caching ;)

[ptelu]

yeah makes sense, cant use it everywhere php will run out of memory eventually when we use it to much. Will look at yii's caching

[Shnoulle]

Currently : it's a static var :). I don't ask to put it in cache (maybe in future), just more clear name :)

[lajosarpad]

I also propose the creation of a protected static $questionThemeCache = []; data member to make the file more readable and the cache more accessible.

[Shnoulle]

protected static $questionThemeStatic = [] ;)

[Shnoulle]

Maybe check more on

if (!empty($this->currentGroupSeq) && $this->currentGroupSeq > 0) {

Something like
if($surveyId && LimeExpressionManager::getLEMsurveyId() == $surveyId && (!empty($this->currentGroupSeq) && $this->currentGroupSeq > 0 ) {

It was call without qid on setVariableAndTokenMappingsForExpressionManager

And this function is used in Logic file.

(updated to comment : think it can show not remlated Group question in Admin part.

I public part : it's always OK, and can really improve.

[lajosarpad]

This looks good, but I would avoid using static variables for caching.

[lajosarpad]

I also propose the creation of a protected static $questionThemeCache = []; data member to make the file more readable and the cache more accessible.

[Shnoulle]

This looks good, but I would avoid using static variables for caching.

It's not caching, it's static . Reason why i ask renaming ;)

[lajosarpad]

Why do you use QuestionTheme here?