Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #19440: Pressing enter in question code circumvents validation #3758

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Feb 23, 2024

Dev: pattern : only alphanum OR do not update on questionCode
Dev: keypress control on questionCode
Dev : add/remove CustomValidaty dynamically
Dev: use Simulate a click on first submit button to validate other element

Dev: pattern : only alphanume OR do not update
…ation

Dev: keypress control
Dev : add/remove CustomValidaty dinamically
Dev: use Simulate a click on first submit button to validate other element
@Shnoulle Shnoulle changed the title Fixed issue #19440 : basic validation on question code Fixed issue #19440: Pressing enter in question code circumvents validation Feb 23, 2024
@c-schmitz
Copy link
Contributor

error
GEtting an error when pressing Enter on a normal question without subquestions/answer options.

@c-schmitz c-schmitz added Test failed Someone tested the PR and it did not work as expected. Please check out the comments. and removed Needs testing labels Feb 26, 2024
@c-schmitz c-schmitz added Tested OK This PR has been tested by QA and works as expected Code review done Version checked for code issue without testing and removed Needs testing Test failed Someone tested the PR and it did not work as expected. Please check out the comments. labels Feb 26, 2024
@c-schmitz c-schmitz merged commit ca7694c into master Feb 26, 2024
20 checks passed
@c-schmitz c-schmitz deleted the bug/19440_ValidationNotDoneWhenPressEnter branch February 26, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
2 participants