Task/lb 132 encoding problems with the body of notification emails #3775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-schmitz
requested changes
Mar 5, 2024
c-schmitz
approved these changes
Mar 7, 2024
marticos
deleted the
task/LB-132-encoding-problems-with-the-body-of-notification-emails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix for "Save Survey Details" email.
This adds the "unescaped" parameter to the translation function to avoid escaping special characters for the body of the mail that is not supposed to be in HTML format.
This affects languages that uses apostrophes like Catalan, Portuguese and so on.
Test instructions:
Please create a survey, for example, in Catalan or use a test survey and change the main language to Catalan.
Start the survey and use the functionality "Continue later" in the survey options in the upper right corner.
Field the required forms and check your email for the translated text.
Actual result:
Gràcies per desar l'enquesta en curs...Expected result:
Gràcies per desar l'enquesta en curs...Thanks.