Dev: #19452: Improve usage of getQuestionAttributes DataEntry #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lajosarpad
requested changes
Mar 7, 2024
| $qidattributes = []; | ||
| if (isset($fname['qid']) && isset($fname['type'])) { | ||
| $qidattributes = QuestionAttribute::model()->getQuestionAttributes($fname['qid']); | ||
| $qidattributes = QuestionAttribute::model()->getQuestionAttributes(Question::model()->findByPk($fname['qid'])); |
There was a problem hiding this comment.
This is compatible with our goals of how we want to use getQuestionAttributes, that is, we intend to pass question objects rather than question ids to it, but let's load the questions separately in a single query rather than running an individual query for each question.
There was a problem hiding this comment.
Yep, maybe check if we call it multiple times ( same qid for subquestions).
Didn't get it in memory, just keep last qid done since we call sub question in a raw.
There was a problem hiding this comment.
Updated : usage on question object in one another question.
Shnoulle
added
Needs code review
Needs testing
Needs update by author
and removed
Needs update by author
labels
…n::model()->findByPk( when it's neeed Dev: not for other question, and not in other foreach
Shnoulle
commented
Mar 19, 2024
| @@ -822,7 +827,7 @@ public function editdata($subaction, $id, $surveyid) | |||
| $questionInput .= ">{$optionarray['answer']}</option>\n"; | |||
| } | |||
| } | |||
| if ($oQuestion->other == "Y") { | |||
| if (($oQuestion->other ?? "N") == "Y") { | |||
lajosarpad
approved these changes
Mar 19, 2024
kevin-foster-uk
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.