Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #19484: File upload question - max_num_of_files problem #3794

Merged
merged 3 commits into from Mar 26, 2024
Merged

Fixed issue #19484: File upload question - max_num_of_files problem #3794

merged 3 commits into from Mar 26, 2024

Conversation

gabrieljenik
Copy link
Collaborator

No description provided.

@c-schmitz c-schmitz added Code review done Version checked for code issue without testing and removed Needs code review labels Mar 20, 2024
@Shnoulle
Copy link
Collaborator

You fix

LimeSurvey/application/controllers/ResponsesController.php

Line 213 in 6d7947e

for ($i = 0; $i < $qidattributes['max_num_of_files']; $i++) {
on a second stage ?

Shnoulle
Shnoulle approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@Shnoulle Shnoulle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great improvement to check $id at start !
And needed here !

@tiborpacalat tiborpacalat added Tested OK This PR has been tested by QA and works as expected and removed Needs testing labels Mar 26, 2024
@tiborpacalat tiborpacalat merged commit c16d1df into master Mar 26, 2024
20 checks passed
@tiborpacalat tiborpacalat deleted the bug/19484--File-upload-question---max_num_of_files-problem branch March 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-schmitz c-schmitz c-schmitz approved these changes

@Shnoulle Shnoulle Shnoulle approved these changes

Assignees
No one assigned
Labels
Code review done Version checked for code issue without testing Tested OK This PR has been tested by QA and works as expected
Projects
None yet
Milestone
No milestone
5 participants
@gabrieljenik @Shnoulle @c-schmitz @tiborpacalat @lapiudevgit