DEV: Add comments about URLs on CLI #3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
gabrieljenik
commented
Apr 9, 2024
gabrieljenik
commented
- Comments on config.php about baseUrl and publicurl (related to 18961)
- Comments on config.php about baseUrl and publicurl (related to 18961)
Shnoulle
approved these changes
Apr 29, 2024
Shnoulle
reviewed
Apr 29, 2024
| . "\t\t" . "'debugsql'=>0, // Set this to 1 to enanble sql logging, only active when debug = 2" . "\n" | ||
| . "\n" | ||
| . "\t\t" . "// If URLs generated while running on CLI are wrong, you need to uncomment the following line and set your" . "\n" | ||
| . "\t\t" . "// public URL (the URL facing survey participants). You will also need to set the request->baseUrl in the section above." . "\n" |
There was a problem hiding this comment.
But ? Set only publicurl work good before in CLI too ?
No ?
There was a problem hiding this comment.
What do you mean by "before"?
As to give some context, this is a followup on 18961
Shnoulle
added
Code review done
Shnoulle
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.