Fixed issue #19404: unable to export survey with PHP 8.0 #3845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev: don't include @attributes array in xml exported Dev: loose attributes, but are unused in case of survey export
| @@ -3144,6 +3144,11 @@ function writeXmlFromArray(XMLWriter $xml, $aData, $sParentKey = '') | |||
| { | |||
| $bCloseElement = false; | |||
| foreach ($aData as $key => $value) { | |||
| if ($key == "@attributes") { | |||
There was a problem hiding this comment.
Is this the right place for this filter?
This function is a writer. Should also have the logic for filtering the sources?
Maybe here better fit?
https://github.com/LimeSurvey/LimeSurvey/pull/3845/files#diff-1aecd900cde469d4c2ba64ab989062a075ed3ff9378180051d812b127a929dfeR3205
There was a problem hiding this comment.
Is this the right place for this filter?
I don't know :)
You're right about the place it was added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev: don't include @attributes array in xml exported
Dev: loose attributes, but are unused in case of survey export