fixed issue #19570: javascript exception on survey taking on browsers…

[TonisOrmisson]

Fixed issue #19570: javascript exception on survey taking on browsers not supporting localstorage

Since I am not sure which calls are for admin or only for survey, I changed usages that directly fixed the issue I was facing (checking timers) and some that seemed possible.

Should have no change on browsers having localStorage

[TonisOrmisson]

Also affects previous versions since ~sept 2020, so current V5/V3

[TonisOrmisson]

@Shnoulle im not sure what the standard is here. Can the "needs testing" label be removed. You added the label after I said I had not done any testing. After that I did actual testing and some code adjustments based on that. What is needed to be done to move on with merging this?

[Shnoulle]

@Shnoulle im not sure what the standard is here. Can the "needs testing" label be removed. You added the label after I said I had not done any testing. After that I did actual testing and some code adjustments based on that. What is needed to be done to move on with merging this?

@tiborpacalat need to test before it was merged. It's the current way to do

1. Another dev do some review
2. Tibor with help of user or other dev do a real test

Edit :l original developer can not be the final tester … best if test himself too