Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue #12113 : fix invalid QubQUetsions when activate #633

Merged
merged 1 commit into from Feb 7, 2017
Merged

Fixed issue #12113 : fix invalid QubQUetsions when activate #633

merged 1 commit into from Feb 7, 2017

Conversation

Shnoulle
Copy link
Collaborator

@Shnoulle Shnoulle commented Feb 6, 2017

  • add a Questions in Survey model fixer for all other language
  • use qid for question and title for subquestion : this broke Survey SQL
  • we must have same qid+title then we can directly delete whole qid (no test on parent_qid)
  • did we must log it ? In log("X questions are deleted",'info',application.survey.???) for example

@Shnoulle
Fixed issue #12113 : fix invalid SubQuetsions when activate
3e59642 
Dev: add a Questions fixer for all other language
Dev: use qid for question and title for subquestion : this broke Survey SQL
Dev: we must have same qid+title then we can directly delete whole qid (no test on parent_qid)
Dev: did we must log it ? In log("X questions are deleted",'info',application.survey.???) for example
@Shnoulle Shnoulle force-pushed the master_12113_InvalidSubQuestions2 branch from 15b5569 to 3e59642 Compare February 6, 2017 18:36
@c-schmitz c-schmitz merged commit 8d6b7bf into LimeSurvey:master Feb 7, 2017
@Shnoulle Shnoulle deleted the master_12113_InvalidSubQuestions2 branch April 5, 2022 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Shnoulle @c-schmitz