Admin508fixes #730
Merged
Admin508fixes #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shnoulle
reviewed
Jun 29, 2017
| @@ -25,7 +25,7 @@ | |||
|
|
|||
| <!-- Create --> | |||
| <li role="presentation" <?php if($active=='create'){echo 'class="active"';}?>> | |||
| <a data-toggle="tab" href='#general'> | |||
| <a role="tab" data-toggle="tab" href='#general'> | |||
There was a problem hiding this comment.
Think we must add role="tabpanel" after http://accessibility.athena-ict.com/aria/examples/tabpanel2.shtml :)
Shnoulle
reviewed
Jun 29, 2017
| @@ -698,7 +698,7 @@ if ('ab'.substr(-1) != 'b') { | |||
| function linksInDialog() | |||
| { | |||
| $(function () { | |||
| var iframe = $('<iframe id="dialog" allowfullscreen></iframe>'); | |||
| var iframe = $('<iframe id="dialog" title='+$(this).attr("title")+' allowfullscreen></iframe>'); | |||
There was a problem hiding this comment.
I'm unsure of the dynamic iframe real accessibility :. (not RGAA or 508, but : real accessibility ;) )
Shnoulle
reviewed
Jun 29, 2017
| iframe.contents().find('head').append('<title>'+$(this).attr("title")+'</title>'); | ||
| $('.ui-dialog-titlebar-close').append('<span class="sr-only">Close</span>'); |
There was a problem hiding this comment.
I think we have a LS.Lang. javascript for extending :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further 508 cleanup