fix issue #08013: 'printanswershonorsconditions' does not work #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV: implementation was missing in getFullResponseTable() and PrintanswersControllers.php
| @@ -6013,7 +6013,7 @@ function getQuotaCompletedCount($iSurveyId, $quotaid) | |||
| * @param mixed $sLanguageCode | |||
| * @param boolean $bHonorConditions Apply conditions | |||
| */ | |||
| function getFullResponseTable($iSurveyID, $iResponseID, $sLanguageCode, $bHonorConditions=false) | |||
| function getFullResponseTable($iSurveyID, $iResponseID, $sLanguageCode, $bHonorConditions=true) | |||
There was a problem hiding this comment.
Needed to change default ? Seeing at top line : you send good boolean before .
There was a problem hiding this comment.
The $bHonorConditions was not used in the if-condition later on. (lines 6029/6055)
So, by default, the getFullResponseTable()-function behaved like $bHonorConditions was set to true. (By default, getFullResponseTable() only gave "relevant" answers).
There was a problem hiding this comment.
Oh yes,
A function parameters not used .... it's really a bad issue .
There was a problem hiding this comment.
Will check if the function is called somewhere WITH this parameter in other files...so we do no get surprises.
I will also make the changes for 2.05 and issue another pull request, ok?
mennodekker
added a commit
that referenced
this pull request
Jul 30, 2013
Fixex issue #8013: 'printanswershonorsconditions' does not work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEV: implementation was missing in getFullResponseTable() and
PrintanswersControllers.php