Merge to master #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. see #6403 for a bit more detail .
…ons in their names
The AST cache checks this propety first and returns it.
The reason I think is to not waste an OrdereCollection for each method that has no Pragmas. This PR changed it to be initialized with an empty array (which later will be shared when we enable literal sharing) It changes to use an array for storage, this is no problem as adding pragmas is not happening at afte ran AST is created (they are created bu the compiler once).
"Debug lines to help review. Could be removed after a settling in period" - This PR removes all the references to the debug ivar (and the related halt sends) - It cleans up the test What needs to be done later is to remove the debug ivar, that can not be done in a running image.
Based on Pharo 7.0 implementation which doesn't have this issue.
…pertiesDo Typo in handle:about:forProppertiesDo:
…trategy-class-comment Small typo in ReExceptionStrategy class comment
…s-to-have-no-Uncategorized-classes-in-the-package Add a lint rule for classes to have no "Uncategorized" classes in the package
…in-package-Refactoring-Tests-Core Tag uncategorized classes in package Refactoring-Tests-Core
DelayBasicScheduler had debug code left from review
…ethodNode RBMethodNode #pragmas is the only instance variable for AST children that has an accessor checking for nil
[fix] remove itemFilterName for the spotter, as it seems to be unused…
…-on-failed-parsing-number-with-high-radix Fixes #6993 against P9: Incorrect error message on failed parsing of a number with high radix
…ge-leaks Do not add DoIts to the cache for now. fixes #7955
remove unused ivar DelayBasicScheduler by doing a PR directly from GitHub
…eReporter-should-be-splitted- Move business logic from new tools to system-support
…the-traitBuilder 8150-Trait-creation-should-use-the-traitBuilder
…nds-non-implemented-call 8127-FFICalloutAPITestmethod2-sends-non-implemented-call
…r-DelayBasicScheduler remove unused ivar DelayBasicScheduler
Add `visitSelectorNode:`
…iable and wrong class creation method
8145-Cleaning-subclass-users
Fix testCreationByUnnamed
…when-used-with-leadingChars Fix broken (deprecated) UTF8TextConverter
…aitTest-are-failing 8181-When-fluid-class-on-two-traitTest-are-failing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.