Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all requirements #136

Merged
merged 7 commits into from
Feb 20, 2024
Merged

Conversation

Jerakin
Copy link
Contributor

@Jerakin Jerakin commented Feb 19, 2024

Summary

A lot of requirements have security warnings and looks quite out of date.
It's good praxis to keep up to date.

Details

I tested it as much as I could by navigated through the whole app and could not find any other errors.
This can be a breaking change so it needs to be thoroughly tested, so the more eyes that takes a look the better.

A lot of requirements have sequrity warnings and looks quite out of date.
It's good praxis to keep up to date.
@Jerakin
Copy link
Contributor Author

Jerakin commented Feb 19, 2024

Right. It seems like wikmd still have support for Python 3.7. The 3.x version of flask is only python 3.8 or higher. 3.7 has already passed the end-of-life stage so it could be a valid consideration to drop the 3.7 support.

I am not sure how most people run it, personally I do it through a docker image so the python version has minimal impact on that.

However that is 100% up to you @Linbreux

@Linbreux
Copy link
Owner

@Jerakin

Updating the requirements was on top of the Todo list!
Thanks for all your efforts to improve wikmd. This is highly appreciated!

We can drop support for 3.7 and start using 3.10 in the CI instead.

Looks like not all tests succeeded. So maybe try to fix this before we merge.

@Jerakin
Copy link
Contributor Author

Jerakin commented Feb 19, 2024

It's a search issue, it seems like watchdog doesn't fire off the events properly. However I have never gotten the search to work on my Windows computer (going back) so I can't really debug it :(

I tried using PollingObserver as this Issue points out #122 but it never worked with that either.

@Linbreux
Copy link
Owner

For now I rolled back the version of the watchdog from v4.0.0 to v2.1.9 so it passes the CI. I'll try to look for a solution in the coming days so we are able to upgrade it again.

@Linbreux Linbreux merged commit 786d2d5 into Linbreux:main Feb 20, 2024
6 checks passed
@Jerakin Jerakin deleted the feat/requirements_update branch February 21, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants