Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove except Exception and except BaseException lines #139

Open
manut opened this issue Jan 5, 2018 · 3 comments
Open

remove except Exception and except BaseException lines #139

manut opened this issue Jan 5, 2018 · 3 comments
Labels
QA enhancement

Comments

@manut
Copy link
Contributor

manut commented Jan 5, 2018

it's hard to debug if a non expected exception is handled accidently..
@manut
Copy link
Contributor Author

manut commented Apr 26, 2018

It is done 73 time in devel/elbe-3.0 at the moment:

elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/asyncworker.py: except Exception as e:
elbepack/commands/add.py: except Exception as e:
elbepack/commands/add.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/daemons/soap/faults.py: except Exception as e:
elbepack/dbaction.py: except Exception as e:
elbepack/elbeproject.py: except Exception as e:
elbepack/elbeproject.py: except Exception as e:
elbepack/elbeproject.py: except Exception as e:
elbepack/gpg.py: except Exception as ex:
elbepack/gpg.py: except Exception as ex:
elbepack/gpg.py: except Exception as ex:
elbepack/gpg.py: except Exception as ex:
elbepack/licencexml.py: except Exception as e:
elbepack/updated.py: except Exception as err:
elbepack/updated.py: except Exception as e:
elbepack/updated.py: except Exception as err:
elbepack/updated.py: except Exception as err:
elbepack/asyncworker.py: except BaseException:
elbepack/asyncworker.py: except BaseException:
elbepack/commands/add.py: except BaseException:
elbepack/commands/chg_archive.py: except BaseException:
elbepack/commands/chg_archive.py: except BaseException:
elbepack/commands/chg_archive.py: except BaseException:
elbepack/commands/get_archive.py: except BaseException:
elbepack/commands/get_archive.py: except BaseException:
elbepack/commands/pin_versions.py: except BaseException:
elbepack/commands/pin_versions.py: except BaseException:
elbepack/commands/show.py: except BaseException:
elbepack/commands/updated.py: except BaseException:
elbepack/daemons/soap/esoap.py: except BaseException:
elbepack/db.py: except BaseException:
elbepack/db.py: except BaseException:
elbepack/dbaction.py: except BaseException:
elbepack/efilesystem.py: except BaseException:
elbepack/efilesystem.py: except BaseException:
elbepack/efilesystem.py: except BaseException:
elbepack/efilesystem.py: except BaseException:
elbepack/efilesystem.py: except BaseException:
elbepack/filesystem.py: except BaseException:
elbepack/projectmanager.py: except BaseException:
elbepack/templates.py: except BaseException:
elbepack/updated.py: except BaseException:
elbepack/updated.py: except BaseException:
elbepack/updated.py: except BaseException:
elbepack/updated.py: except BaseException:
elbepack/updated_monitors.py: except BaseException:
elbepack/updated_monitors.py: except BaseException:
elbepack/validate.py: except BaseException:
elbepack/virtapt.py: except BaseException:
elbepack/virtapt.py: except BaseException:
elbepack/xmlpreprocess.py: except BaseException:
test/updated.py:except BaseException:
test/updated.py:except BaseException:
test/updated.py: except BaseException:
test/updated.py: except BaseException:

@manut
Copy link
Contributor Author

manut commented Apr 26, 2018 •
edited

would be good to fix this before doing #146

@manut manut mentioned this issue May 8, 2018
Closed
@manut
Copy link
Contributor Author

manut commented May 8, 2018

Take care about informations mentioned at #158 - this issue is just closed, because it's a duplicate of this one, but the information may be useful if fixing this one.

manut pushed a commit that referenced this issue Aug 16, 2018
virtapt: print execptions that are ignored
bd0f42a 
catching and passing BaseExceptions is a nogo and a known bug:
github #139

but silently ignoring this, is even worse. Add at leas a print
to get some informations what's going on.

Signed-off-by: Manuel Traut <manut@linutronix.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bene42 @manut