Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elbe initvm create with xmls including variant attributes fails #194

Closed
manut opened this issue Nov 21, 2018 · 1 comment
Closed

elbe initvm create with xmls including variant attributes fails #194

manut opened this issue Nov 21, 2018 · 1 comment
Labels
bug
Milestone
elbe15

Comments

@manut
Copy link
Contributor

manut commented Nov 21, 2018

XML file is inavlid: examples/x86_64-docker.xml:34 error Element 'diet', attribute 'variant': The attribute 'variant' is not allowed.
examples/x86_64-docker.xml:35 error Element 'pkg-list', attribute 'variant': The attribute 'variant' is not allowed.

probably xmlpreprocess isn't called
@manut manut added this to the elbe3 milestone Dec 3, 2018
manut pushed a commit that referenced this issue Feb 25, 2019
initvm create: less strict XML check on project XML
de1e265 
On `elbe initvm create project.xml` with project.xml containing variants the
ElbeXML check on the XML file does not do preprocessing and fails.

However, later on the preprocessing is done anyway.
So just use an etree() call instead to do the XML check.
This closes issue #194.

Fix the user facing typo which appears in the bug report.

Signed-off-by: Bastian Germann <bage@linutronix.de>
Signed-off-by: Manuel Traut <manut@linutronix.de>
Reviewed-by: Manuel Traut <manut@linutronix.de>
@manut
Copy link
Contributor Author

manut commented Feb 25, 2019

fixed by de1e265

@manut manut closed this as completed Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
elbe15
Development

No branches or pull requests
1 participant
@manut