-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Corrected internal Axis widget name of Coolant label
The label 'Coolant:' was misnamed lubel. It is not related to lubing, but to cooling, so rename to 'coolantl' instead. Adjusted Axis simulation configs to also simulate coolant to get the label to show up during simulation.
- Loading branch information
1 parent
7b4d5f6
commit 8652ca8
Showing
5 changed files
with
12 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# Fake the existance of coolant options | ||
loadrt and2 count=3 | ||
addf and2.0 servo-thread | ||
addf and2.1 servo-thread | ||
net flood iocontrol.0.coolant-flood => and2.0.in0 | ||
net mist iocontrol.0.coolant-mist => and2.0.in1 | ||
net lube iocontrol.0.lube => and2.1.in0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8652ca8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit broke my axis_mm simulation.
Error:
./cooling.hal:7: Pin 'iocontrol.0.lube' does not exist
8652ca8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
8652ca8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on branch 2.9 but not in master branch. I'll have a look later on why this is, I guess iocontrol changed.
8652ca8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed iocontrol got changed and lube was removed.
There is already an issue open where this is kinda discussed:
#2532
So imma watch there what the result is going to be.