Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AXIS/etc show all gcode errors as 'Unable to open file <>' #308

Closed
jepler opened this issue Jul 22, 2017 · 0 comments
Closed

AXIS/etc show all gcode errors as 'Unable to open file <>' #308

jepler opened this issue Jul 22, 2017 · 0 comments
Assignees
@jepler
Labels
affects axis affects gmoccapy affects gscreen affects master affects 2.7 bug

Comments

@jepler
Copy link
Contributor

jepler commented Jul 22, 2017

Here are the steps I follow to reproduce the issue:

  1. Put any bad gcode in a gcode file
  2. open it with AXIS

This is what I expected to happen:

AXIS shows the real error

This is what happened instead:

AXIS shows the error 'Unable to open file <>'

It worked properly before this:

broken in 2.7.10, OK in 2.7.9. Almost certainly broken by #299.

Reported by @andypugh via the mailing list, reproduced by me
@jepler jepler self-assigned this Jul 22, 2017
@jepler jepler mentioned this issue Jul 22, 2017
Merged
cradek pushed a commit that referenced this issue Jul 23, 2017
@dngarrett
External Offsets -- eliminate synch() restrictions
98cc79c 
---------------------------------------------------
(70:rebased to master at 014b9d0 2017-07-20 10:57:58 -0600)

Warning:
Includes unresolved issue (from 2.7 branch):
   #308
pending fix:
   #309
and propagation to master and rebase of this branch
---------------------------------------------------

Prior synch() restrictions are eliminated by changing the
way that external offsets are removed from the current position
information that is used by the interpreter.

Note:
     Stopping on synch() with external offset applied may
     be enabled at compile-time using an option defined
     in nml_intf/canon.cc:
        #define STOP_ON_SYNCH_IF_EXTERNAL_OFFSETS
     This option will be removed in the future.

Signed-off-by: Dewey Garrett <dgarrett@panix.com>
jepler added a commit to jepler/linuxcnc that referenced this issue Jul 26, 2017
@jepler
Test that the Python interpreter prints the right errors
248f4dd 
.. this is a test for LinuxCNC#308
@jepler jepler mentioned this issue Jul 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jepler jepler

Labels
affects axis affects gmoccapy affects gscreen affects master affects 2.7 bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jepler