component thcud.comp

[nkp216]

pin cur_offset not connected anywhere

When I needed it, I did it like this:
................
................
if(!enable){
z_pos_out = z_pos_in;
z_fb_out = z_pos_in; // keep axis motor position fb from being confused
}
cur_offset = offset;
}

And it would be nice to make parameter "correction_vel"
a pin so that you can adjust from the outside

like thise:
pin in float correction_vel "The Velocity to move Z to correct";

[andypugh]

I see no reason that correction_vel could not be a pin. It won't affect any existing HAL files and sounds like it might be useful.
I don't see any reason for the offset to be an internal variable. Your solution seems like it would have the desired effect, but it would make more sense to use the pin value directly throughout.
Hopefully JT can explain if there is a good reason for the separation.

[petterreinholdtsen]

@jethornton Any chance you can explain the reason for the separation?

[jethornton]

It looks like:
pin out float cur_offset "The Current Offset";
is a left over from the copy and paste of thc.comp perhaps but I can't find any reference to it. So maybe I was adding it 10 years ago and never finished it...

JT

[andypugh]

I have made the change to the offset output pin.