Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gmoccapy: fix limit switch issue (#1000) #1453

Merged
merged 4 commits into from Feb 27, 2022

Conversation

hansu
Copy link
Member

@hansu hansu commented Dec 18, 2021

This fixes #1000 (comment)

resolves #1000

@gmoccapy

@gmoccapy
Copy link
Collaborator

Have you checked you solution also with a non trivial kinematics?
IMHO you will need to check the kinematics type, as for jogging in a non trivial kinematics and state not homed, you will need to display the JOINT Button and in a trivial kinematics the axis BUTTON.

@hansu
Copy link
Member Author

hansu commented Dec 19, 2021

@gmoccapy When there is any tripped limit switch, then it would be mentioned in stat.limit, right?
In that case I enable the "ignore limit" checkbox to be able to switch on the machine and move away from the limit switch.
The action is the same as when toggling the estop (except the button manipulation).
'Trivial kinematics' also has its limit switches on joints, so that makes no difference IMHO.

@hansu
Copy link
Member Author

hansu commented Jan 14, 2022

Here is it done in nearly the same way:

def one_or_more_on_limit(self):
for i in range (self.stat.joints):
if self.stat.limit[i]: return True
return False

@hansu hansu force-pushed the gmoccapy-limit-switch-estop branch from f56c927 to 7564f32 Compare February 13, 2022 14:57
@hansu hansu force-pushed the gmoccapy-limit-switch-estop branch from 7564f32 to 2019bde Compare February 13, 2022 15:15
@hansu
Copy link
Member Author

hansu commented Feb 13, 2022

Now it is working perfectly. I verified this on a real machine.

@c-morley
Copy link
Collaborator

Ready to go then?

@hansu
Copy link
Member Author

hansu commented Feb 26, 2022

Yes!

@c-morley c-morley merged commit 55e97f8 into LinuxCNC:master Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ignore-limits"-checkbox in gmoccapy 3.0.9.1 (LinuxCNC 2.8) is not displayed correctly
3 participants