Test clang builds on github to detect when it break. #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it possible to add ubuntu-latest or Jammy (Jammy Jellyfish) / 22.04? It's a bit more in-sync, I love this PR though! Focal / 20.04 is on only Clang 10 from 2 years ago, 5 versions behind. |
petterreinholdtsen
force-pushed
the
github-ci-clang
branch
from
4a5ef8e
to
84912ee
Compare
Also adjust the normal rip build to use eatmydata when installing packages, to speed up the test.
petterreinholdtsen
force-pushed
the
github-ci-clang
branch
from
84912ee
to
f2b36d9
Compare
|
I leave it to others to decide whoch Ubuntu versions to build on. I do not have an opinion there. |
Closed
|
This is great. It might make sense to do |
|
[Sebastian Kuzminsky]
This is great.
Time to merge?
It might make sense to do `rip-and-test-clang` in docker, so you can
choose a newer Ubuntu (and/or Debian) distro to run it on.
Note, the clang errors reported were also triggered in clang 11.0, so
for this error it is not need for a newer Ubuntu.
…--
Happy hacking
Petter Reinholdtsen
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.