2.9: Several cosmetic and minor bugfixes for touchy #2311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the first program load, it would always scroll to the bottom of the list, because it discovered upon polling that the new empty gcode file in /tmp that is loaded initally is "new", and it would walk through the listing looking for that name.
Don't expand it into multiple lines, or cause the window to widen because you get a long error. Just chop it off.
|
Ref the error messages, it would be nice if there was a way to see the previous error message. If you get two at a time then you only see the last. (which is often a consequence of the first, and so not particularly diagnostic) |
|
Thanks, yes I could imagine a scrolling list on an additional tab to solve that problem. But these changes don't make that problem better or worse; they do improve the way it works currently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the filechooser fix, I confirmed that loading a gcode file in another UI does cause touchy to update the screen correctly. The rest are cosmetic changes.