Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.9 Updates to getting-linuxcnc #2522

Merged
merged 3 commits into from Jun 18, 2023
Merged

2.9 Updates to getting-linuxcnc #2522

merged 3 commits into from Jun 18, 2023

Conversation

rodw-au
Copy link
Contributor

@rodw-au rodw-au commented Jun 12, 2023

Replaced #2496

@rodw-au rodw-au mentioned this pull request Jun 12, 2023
@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 12, 2023

@sebastiankuzminsky @hansu
Rebased against 2.9 branch as requested

@andypugh
Copy link
Collaborator

Discussed at the Norway meetup.

@andypugh andypugh merged commit d25f2a6 into LinuxCNC:2.9 Jun 18, 2023
11 checks passed
@rene-dev
Copy link
Collaborator

the linuxcnc norway meeting approves this PR.

@dpslwk
Copy link
Contributor

dpslwk commented Jun 19, 2023

in the Updating Linuxcnc on Debian Bookworm (X86 only) section
the previous instructions for adding the custom linuxcnc repositories took the safe option of adding them into a serpate sources.list file namely /etc/apt/sources.list.d/linuxcnc.list

yet these new instructions now have users directly modifying the base list file /etc/apt/sources.list
(it even includes a waring to say messing with this is dangerous)

adding custom repositories via separate files under /etc/apt/sources.list.d/sources.list.d/ is I believe the preferred way / best practice

@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 19, 2023

in the Updating Linuxcnc on Debian Bookworm (X86 only) section the previous instructions for adding the custom linuxcnc repositories took the safe option of adding them into a serpate sources.list file namely /etc/apt/sources.list.d/linuxcnc.list

yet these new instructions now have users directly modifying the base list file /etc/apt/sources.list (it even includes a waring to say messing with this is dangerous)

adding custom repositories via separate files under /etc/apt/sources.list.d/sources.list.d/ is I believe the preferred way / best practice

Thaats exactly what this line does
sudo nano /etc/apt/preferences.d/99linuxcnc-uspace
Ref: https://github.com/LinuxCNC/linuxcnc/blob/2.9/docs/src/getting-started/getting-linuxcnc.adoc?plain=1#L254

Are you referring to another section of the code?

@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 19, 2023

My mistake, you are looking here:
https://github.com/LinuxCNC/linuxcnc/blob/2.9/docs/src/getting-started/getting-linuxcnc.adoc?plain=1#L295
I am no expert with apt. Can that be moved to /etc/apt/preferences.d/99linuxcnc-uspace?

@dpslwk
Copy link
Contributor

dpslwk commented Jun 19, 2023

im talking about this line

sudo echo "deb http://buildbot2.highlab.com/debian/ bookworm 2.9-uspace" | sudo tee -a /etc/apt/sources.list

and the warning on this line

Hit Control-O, Y, Control-X to save the file and exit nano. Then type the following commands. Make sure you don't make a mistake or you could corrupt a critical linux config file /etc/apt/sources.list

I would have that line 295 as
sudo echo "deb http://buildbot2.highlab.com/debian/ bookworm 2.9-uspace" | sudo tee -a /etc/apt/sources.list.d/linuxcnc.list
which is in the same style as before

. Add the apt repository:
+
----
echo deb https://linuxcnc.org/ buster base 2.8-rt | sudo tee /etc/apt/sources.list.d/linuxcnc.list
echo deb-src https://linuxcnc.org/ buster base 2.8-rt | sudo tee -a /etc/apt/sources.list.d/linuxcnc.list
----

then the warning is then not needed

I'm not so familiar with /etc/apt/preferences.d/ but I believe all that is OK

@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 19, 2023

Thanks.

From what I can see, files in preferences.d are parsed in alphabetical order, so If its spread over more than one file, I think we should be using 10linuxcnc.list or similar so it is loaded before the pinning priorities are set. It makes sense for any pinned repos to be actioned last so two files are required in case there are other files added. (I did observe files for Google Chrome and Teamviewer on one Bullseye PC I have.)

I could not find where the repositories are set in the linuxcnc repos for guidance. I thought they might have been under the live-build repo but could not find them. I have not installed Buster for years... Can anyone advise where to look (or share the file here)?

It would be nice if the additional files could be hosted on the linuxcnc domain so we could just use wget. Can this be done?

This is all new now its in a distro's repository :)

@dpslwk
Copy link
Contributor

dpslwk commented Jun 19, 2023

no the line
deb http://buildbot2.highlab.com/debian/ bookworm 2.9-uspace
needs to be in a file under /etc/apt/sources.list.d/(what im suggesting) or added to /etc/apt/sources.list (as currently written)

it will not work in a file under /etc/apt/preferences.d/

you know what ill just file a quick PR

dpslwk added a commit to dpslwk/linuxcnc that referenced this pull request Jun 19, 2023
@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 19, 2023

Sorry, my mistake. I thought it was under the same folder. Makes sense now.

@hansu
Copy link
Member

hansu commented Jun 19, 2023

@petterreinholdtsen I wonder whether it's correct that the list "Alternate Install Methods" is that short now.
You extended the list in https://github.com/LinuxCNC/linuxcnc/pull/2199/files and maybe those changes should be re-added?

@rodw-au
Copy link
Contributor Author

rodw-au commented Jun 19, 2023

My trimming was done without knowledge of #2199 but is similar in the changes.
I left Bullseye off the list because there was no method to install it from repositories and no ISO for it.

Even with the new buildbot supporting it, I think that still makes sense because the 5.x kernels in Bullseye will be more likely to cause problems than Bookworm's 6.x kernels (I have tested every released kernel from 5.10 to 6.1x and even past that eg. 6.2 and 6.3).

We deliberately refer people to the 2.8 Docs if the user wants to use kernels that are over 10 years old.
Adding them back in is only going to add clutter for new users because of the number of gotchas a user could face installing linuxcnc from the Bookworm repos.

Make no mistake this was a major rewrite and it had to cull a lot of obsolete info to make room for the necessary new content.

If interested, I found this video about installing Bookworm which I thought was very well done over the weekend. I intend to share it on the forum.
https://youtu.be/gddlhr9ST9Y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants