-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend M6 remap to allow return to orig. position #2706
Open
VectorHasting
wants to merge
3
commits into
LinuxCNC:2.9
Choose a base branch
from
VectorHasting:2.9
base: 2.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 22, 2023
-
Extend M6 remap to allow return to orig. position
Made a switch in the Versa_toolsetter section that give the option to direct the return point to either: Option 1 (Default if no option specified): Gmoccapy default already released with QtDragon: Only returns to the Change_Position z height, as programmed at: configs > sim > gmoccapy > macros > change.ngc Option 2: AxisDefault Return to the XYZ tool change position, as programmed at: configs > sim > axis > remap > manual-toolchanges-with-tool-length- switch > nc_subroutines > Manual_change.ngc Option 3: New QtDragon option: Return the tip of the current changed tool to the XYZ position of the tip of the old tool, moving to Tool Change Z first, then Original XY, then down to new offset Z. Also moved some error checking earlier. Changes made to documentation: All changes are limited to the “Auto Tool Measurement” section. (Currently, LinuxCNC#14) except for 1. fixing one typo, 2 adding a [[sub:touch-plate]] tag to the Touch plate section so that the Auto Tool section can redirect readers there. 3. Increase the Table of Contents Levels depth to 4 (default is 2) In the “Auto Tool Measurement” Section 14, I made the following changes: Created a section at the beginning called “Overview” (new 14.1) In this section I explain that this procedure intends to use two probes. be done with one or two sensors. The one sensor only method requires the Tool Switch and is described as One Sensor Workflow. The two sensor method makes use of an additional spindle probe, also called a Renishaw probe. It directs people with repeatable tool holders to the Touch Plate section. It directs those with automatic tool changers to axamine the axis remap code rack-toolchange. It then splits the documentation into “Work Flow Overview” which includes most of the documentation above the QtDragon_HD screen intact. This becomes section 14.2 In this section, I moved pre-requisites earlier (ie, instead of warning near the end to have Use Tool sensor selected, include this along with other pre-requisites under the Important heading near the top. In the “sequence of events” section I added the extra possibilities of this ngc code modification: The INI setting [RETURN_OPTION] can elicit additional behavior after the return to the [TOOL_CHANGE] Z position: • If INI’s [RETURN_OPTION] = 1: (or if it is undefined), no further action. This is the default behavior of the GMOCCAPY M6 remap procedure • If INI’s [RETURN_OPTION] = 2: Continue with a Rapid Move to the X and Y position defined in INI’s [TOOL_CHANGE] X and Y settings. This is the default behavior of the AXIS gui’s M6 remap procedure. • If INI’s [RETURN_OPTION] = 3: Rapid Move to the original X and Y position at the moment the tool-change started, then Rapid Move down to the now offset Z position at the moment the tool-change started. This effectively moves the tool head back to the position just prior to the tool change. This is new behavior exclusive to QtDragon as of 4th quarter 2023. Added another section following that one called “Workflow Example” (new section 14.2) Renamed the next section to be clear it only applies to the QtDragon_hd interface (was 14.1, now 14.4) All the following sections automatically increased in numbering. Added the RETURN_OPTION explanations to what is now section 14.6.3 “The Tool Sensor Section” Corrected “TOOLCHANGE” in section 14.6.3 to be “CHANGE_POSITION”
Configuration menu - View commit details
-
Copy full SHA for b2634c6 - Browse repository at this point
Copy the full SHA b2634c6View commit details
Commits on Jul 13, 2024
-
This update makes the following changes, per comments on 2/17/2024 1. Changes the stock remap to unconditionally return the machine to the position it was in when the remap was called. (This gets rid of a previous iteration that added a 'return_option' variable to the .ini file.) 2. Changes to documentation to reflect this change. In full disclosure: This change will now also have the effect of largely reversing PR # 2562, because this version goes back to using G38.2. I do that because in practice G38.3 (the main change in PR 2562) does not allow the QtDragon implementation to display probing errors to the user. This this version will restore that functionality. This code does, however, retain the order of additional error-checking that was changed in PR # 2562. These changes will also hopefully pass error checking because they are based on an updated fetch of 2.9.
Configuration menu - View commit details
-
Copy full SHA for 8caa075 - Browse repository at this point
Copy the full SHA 8caa075View commit details -
Configuration menu - View commit details
-
Copy full SHA for 391f8cd - Browse repository at this point
Copy the full SHA 391f8cdView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.