New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gmoccapy - Patch for Combination M61 + G4 #2489 - Version 2 #2841
base: 2.9
Are you sure you want to change the base?
Conversation
This patch ensures that the automatic command G43 is not executed immediately, but when the LCNC is in IDLE mode.
The idea as described sounds fine, but I think we need Norbert (@gmoccapy ) to look at the code to be sure it will work without unintended side-effects. |
I agree with Andy. |
I would like to add some more information about what this patch is good for. Currently, Gmoccapy behaves randomly when we want to change the tool with G43 active. Sometimes only a tool change is implemented. Sometimes a tool change is performed and the tool table window is closed. I made two examples. In both cases I have G43 active and in both cases I change the tool from tool1 to tool10. |
@gmoccapy Can we at least add this Pull Request to the master branch? The master branch is still in development and could be tested. |
Please do not add this, I do only know one case where the actual way does not work. I do hope to have time to go on developing the GUI in about one year |
@gmoccapy Replace MDI commands:
By changing the parameters: There would be no need to deal with problematic MDI mode switching. Would it be acceptable to you if one of the experienced programmers did it? I understand that you don't want push PR from an amateur like me. That I'm an amateur is a fact, it's not sarcasm. |
This patch ensures that the automatic command G43 is not executed immediately, but when the LCNC is in IDLE mode.