Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

G7x precise mk2 #689

Merged
merged 10 commits into from Feb 28, 2020
Merged

G7x precise mk2 #689

merged 10 commits into from Feb 28, 2020

Conversation

jepler
Copy link
Member

@jepler jepler commented Feb 27, 2020

This builds on the code in #686 to achieve compatibility with the compiler on precise.

@jepler
Copy link
Member Author

jepler commented Feb 28, 2020

@mark-v-d any concerns about the changes introduced by this patch?
b809e50 in particular.

@andypugh andypugh merged commit fe14f64 into LinuxCNC:master Feb 28, 2020
@mark-v-d
Copy link
Contributor

mark-v-d commented Mar 1, 2020

Looks OK, except for flip_state{}. Empty braces means default
initialisation, which is an indeterminate value for int. So that should
be flip_state{0}.

@mark-v-d
Copy link
Contributor

mark-v-d commented Mar 1, 2020

Same for finish{}, which must be finish{0}

@mark-v-d
Copy link
Contributor

mark-v-d commented Mar 1, 2020

Ignore my remarks, that is c++03

@andypugh
Copy link
Collaborator

andypugh commented Mar 1, 2020

Code details aside, we now seem to have clean(ish) compiles on all platforms.
However I am seeing problems with the tests, as is the buildbot.

My test machine is running an experimental RTAI kernel, so might not be representative. But I am getting one failed runtest with 2.8 and 115 fails (113 pass) with master.
I am investigating, but could you run the tests (./scripts/runtests ) on your dev system to see what you get? It takes about 15 minutes to run all tests.

@andypugh
Copy link
Collaborator

andypugh commented Mar 2, 2020

OK, that's a good sign. I will have a look with a preempt-rt system and do some git bisecting to see what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants