configure: revamp *mod detection #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insmod/rmmod are not actually useful to set by configure flag, and none of them are needed on uspace, so replacing them with programs that always succeed (lsmod) or always fail (insmod/rmmod) is OK. Replacing them with "" or failing to AC_SUBST them (done implicitly by AC_PATH_PROG, even though we overrode its result in 2/3 of cases) makes all the scripts bomb. Signed-off-by: Jeff Epler <jepler@unpythonic.net>
|
The claim "none of them are needed on uspace" is false since uspace-plus was merged to master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For freebsd support, @trasz needs configure with uspace to not fail if insmod/rmmod/lsmod are not available. This patch passes on our buildbot, unlike the first one I offered him. http://buildbot.linuxcnc.org/buildbot/builders/0000.checkin/builds/4283