Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for Db2 #3676

Closed
lmsurpre opened this issue May 31, 2022 · 2 comments
Closed

Drop support for Db2 #3676

lmsurpre opened this issue May 31, 2022 · 2 comments
Assignees
@lmsurpre @punktilious
Labels
enhancement New feature or request P3 Priority 3 - Nice To Have removal this change involves removal of a component, class, method, etc

Comments

@lmsurpre
Copy link
Member

lmsurpre commented May 31, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Given the cost/benefit of supporting a unique multi-tenant schema design for Db2, I think it would be in our best interest to drop this support (so we can focus elsewhere).

Describe the solution you'd like
Unless other users/contributors step forward in support of Db2, we should remove it wholesale.
This includes at least:

  • removing the db2 driver (jcc) from the pom.xml and the built installer/container images
  • datasource server.xml and configDropins related to Db2
  • removing db2 from the CI pipeline (replace it with postgresql and/or use chance to conslidate the overall number of tests)
  • any db2-specific code in fhir-database-util, fhir-persistence-schema, and fhir-persistence jdbc
    • anything mentioning "multi-tenant schema" could also be removed
  • project documentation

Describe alternatives you've considered
Continue to support db2, but drop the multi-tenant schema part of it (so it works like all our other db types).

Acceptance Criteria

  1. GIVEN [a precondition]
    AND [another precondition]
    WHEN [test step]
    AND [test step]
    THEN [verification step]
    AND [verification step]

Additional context
Please contact us or comment here if you are dependent on Db2 to continue being supported out-of-the box.
@lmsurpre lmsurpre added enhancement New feature or request P3 Priority 3 - Nice To Have labels May 31, 2022
@lmsurpre lmsurpre mentioned this issue Jun 17, 2022
Closed
@lmsurpre lmsurpre added the removal this change involves removal of a component, class, method, etc label Jul 11, 2022
@lmsurpre
Copy link
Member Author

linking to a review comment that hints that we may be able to remove some related classes when we remove Db2:
#3754 (comment)

@lmsurpre lmsurpre self-assigned this Jul 20, 2022
punktilious added a commit that referenced this issue Jul 20, 2022
@punktilious
issue #3676 drop db2 support - initial code removal
2da2031 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 21, 2022
@punktilious
issue #3676 removed dead code related to Db2
75489a6 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 21, 2022
@punktilious
issue #3676 removed db2 references in documentation
03d95f0 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
@punktilious punktilious mentioned this issue Jul 21, 2022
Closed
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
b16f0c4 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
5915fa6 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
d75059a 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
16e2e0d 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
e3a2aff 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
07115ba 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
4a80bb3 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
eb55f56 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
lmsurpre added a commit that referenced this issue Jul 22, 2022
@lmsurpre
issue #3676 - first pass at replacing db2 with postgres in the contai…
dd943dc 
…nerized e2e tests

Signed-off-by: Lee Surprenant <lmsurpre@merative.com>
punktilious added a commit that referenced this issue Jul 25, 2022
@punktilious
issue #3676 db2 removal
dae4754 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 25, 2022
@punktilious
issue #3676 remove more legacy tenant-specific code
012eb24 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 25, 2022
@punktilious
issue #3676 reinstate call to populate reference tables
2facf01 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre added a commit that referenced this issue Jul 25, 2022
@lmsurpre
Merge pull request #3794 from LinuxForHealth/issue-3676-ci
ca285dd 
issue #3676 - Replace db2 with postgres in containerized e2e tests
punktilious added a commit that referenced this issue Jul 25, 2022
@punktilious
issue #3676 db2 removal merge with ci pipeline changes
b539ba6 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 26, 2022
@punktilious
issue #3676 address review comments
438ba44 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
punktilious added a commit that referenced this issue Jul 26, 2022
@punktilious
issue #3676 removed db2 datasource and related docker test stuff
dab359e 
Signed-off-by: Robin Arnold <robin.arnold@ibm.com>
lmsurpre added a commit that referenced this issue Jul 26, 2022
@lmsurpre
Merge pull request #3803 from LinuxForHealth/ra-remove-db2
15517f1 
issue #3676 remove Db2 support
@lmsurpre
Copy link
Member Author

lmsurpre commented Aug 4, 2022

No specific QA done; will be tested along with everything else

@lmsurpre lmsurpre closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmsurpre lmsurpre

@punktilious punktilious

Labels
enhancement New feature or request P3 Priority 3 - Nice To Have removal this change involves removal of a component, class, method, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lmsurpre @punktilious