Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom operation should support more types being passed from URI #75

Closed
lmsurpre opened this issue Sep 15, 2019 · 5 comments
Closed

Custom operation should support more types being passed from URI #75

lmsurpre opened this issue Sep 15, 2019 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@lmsurpre
Copy link
Member

lmsurpre commented Sep 15, 2019

Describe the bug
While trying to invoke $export operation via GET, it complains that we can't process an input parameter of type instant.

To Reproduce
Invoke export with a request like this: {{http}}://{{host}}:{{port}}/{{basePath}}/$export?_outputFormat=application/fhir+ndjson&_since=2019-01-01T08:21:26.94-04:00&_type=Patient

Additional context
Spec says we should support passing of "primitive" types via URL.

@lmsurpre lmsurpre added the bug Something isn't working label Sep 15, 2019
@prb112
Copy link
Contributor

prb112 commented Sep 15, 2019

It's intentional :) there is a todo in the BulkDataClient to pass the joined list.
defensively - I opted not to pass since only one type is supported at this time.

@lmsurpre
Copy link
Member Author

I really think we should just expand the set of supported types that come in from the URL. Its not a bulk issue; just a limitation of current operation framework impl. Will have PR shortly.

lmsurpre added a commit that referenced this issue Sep 15, 2019
This adds support for all primitive types except for "base64" and
"markdown".

Still needs test.

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre self-assigned this Sep 16, 2019
@lmsurpre lmsurpre added this to the Sprint 1 milestone Sep 16, 2019
@lmsurpre
Copy link
Member Author

lmsurpre commented Sep 17, 2019

I don't think this is really blocked by #55. I just need to add some tests and then I'll close it out.

@prb112
Copy link
Contributor

prb112 commented Sep 17, 2019

was not the intent to block - rather link the two

@lmsurpre
Copy link
Member Author

yeah, i wish they had a "related to". all you can really do then is just mentioned the issue #s in comments.

lmsurpre added a commit that referenced this issue Sep 19, 2019
* Updated MyOperation to accept many optional parameters and return
empty response if nothing was passed.
* Added test to invoke $hello operation with no body and return empty
response.
* Added isEmpty helper in FHIRResponse.

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 19, 2019
Validation now returns warnings and so we should not check for "All OK"
but instead just use the response code.

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
lmsurpre added a commit that referenced this issue Sep 19, 2019
…ery param

1. introduced test for invoking $hello operation with all supported primitive types
2. fixed bug in FHIROperationUtil for missing "id" datatype support
3. enabled FHIROperationTest by default

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants