Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 75 - add tests for invoking custom operation framework with query parms #96

Merged
merged 6 commits into from
Sep 19, 2019
Merged

Issue 75 - add tests for invoking custom operation framework with query parms #96

merged 6 commits into from
Sep 19, 2019

Conversation

lmsurpre
Copy link
Member

@lmsurpre lmsurpre commented Sep 18, 2019 •
edited

Code for addressing issue #75 was added in #77 ...
Now we just need to verify its working (beyond the $export operation).

  1. Fix the MyOperation operation. This was accidentally broken from migrating to R4 but no one noticed since the tests aren't integrated into our build.
  2. Fix the Validation operation tests (e.g. stop looking for "All OK" when there are validation warnings...in past we didn't return warnings)
  3. Update pre-integration test scripts to install the fhir-operation-tests.jar file so that the operation tests can be run as part of the build.
  4. Change mode of scripts under build so they are executable by default
  5. Enable FHIROperationTest in the fhir-server-test TestNG suite by default
  6. Update FHIR Operation Framework to support returning empty responses
  7. Add isEmpty helper on FHIRResponse so client can check for empty responses
  8. Update MyOperation $hello impl to accept optional params of each primitive type (minus base64Binary and markdown)
  9. Add new test to fhir-server-test FHIROperationTest for invoking an operation with each of the allowed input/output types

@lmsurpre lmsurpre force-pushed the issue-75 branch 2 times, most recently from 62669e0 to b57515b Compare September 18, 2019 18:37
@lmsurpre
make fhir-install/docker/copy-dependencies.sh executable
b9a633d 
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
fixup MyOperation and install fhir-operation-tests jar during pre-int…
75939e2 
…egration script

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
add execute permissions to build scripts
a98ab4f 
Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre
issue #75 - update operation framework to allow empty response
b20ae77 
* Updated MyOperation to accept many optional parameters and return
empty response if nothing was passed.
* Added test to invoke $hello operation with no body and return empty
response.
* Added isEmpty helper in FHIRResponse.

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
@lmsurpre
issue #75 - Fix up validation operation tests
2f937c5 
Validation now returns warnings and so we should not check for "All OK"
but instead just use the response code.

Signed-off-by: lmsurpre <lmsurpre@us.ibm.com>
@lmsurpre
issue #75 - test that GET supports passing all primitive types via qu…
b54d203 
…ery param

1. introduced test for invoking $hello operation with all supported primitive types
2. fixed bug in FHIROperationUtil for missing "id" datatype support
3. enabled FHIROperationTest by default

Signed-off-by: Lee Surprenant <lmsurpre@us.ibm.com>
@lmsurpre lmsurpre changed the title WIP Issue 75 - add tests for invoking custom operation framework with query parms Issue 75 - add tests for invoking custom operation framework with query parms Sep 19, 2019
@lmsurpre
Copy link
Member Author

Build and integration tests (including FHIROperationTest) are now working for me:

[INFO] Tests run: 305, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 149.545 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 305, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  02:34 min
[INFO] Finished at: 2019-09-19T11:51:21-04:00
[INFO] ------------------------------------------------------------------------```

@prb112 prb112 added this to the Sprint 1 milestone Sep 19, 2019
@prb112
Copy link
Contributor

prb112 commented Sep 19, 2019

Verified build locally

[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  05:28 min
[INFO] Finished at: 2019-09-19T12:12:30-04:00
[INFO] ------------------------------------------------------------------------

prb112
prb112 approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@prb112 prb112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prb112 prb112 merged commit ff8b363 into master Sep 19, 2019
@prb112 prb112 deleted the issue-75 branch September 19, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prb112 prb112 prb112 approved these changes

Assignees

@lmsurpre lmsurpre

Labels
None yet
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lmsurpre @prb112