feat: add serviceMonitor in the helm chart #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinuxSuRen
added
enhancement
LinuxSuRen
reviewed
Jun 13, 2024
There was a problem hiding this comment.
This CRD is not in the core of Kubernetes. It would be better if you could add a conditional statement. Have it only when enable this feature. Actually, you already have that value but you didn't use it here. Or just forget?
helm/api-testing/values.yaml
Outdated
| @@ -109,3 +109,15 @@ affinity: {} | |||
|
|
|||
| mongodb: | |||
| enabled: false | |||
|
|
|||
| serviceMonitor: | |||
| enabled: true | |||
There was a problem hiding this comment.
I prefer to change this default value to false because This CRD is not in the core of Kubernetes.
There was a problem hiding this comment.
I changed it to false and used.
helm/api-testing/values.yaml
Outdated
Comment on lines
115
to
116
| interval: 15s | ||
| path: /metrics |
helm/api-testing/values.yaml
Outdated
Comment on lines
120
to
123
| prometheus: | ||
| prometheusSpec: | ||
| podMonitorSelectorNilUsesHelmValues: false | ||
| serviceMonitorSelectorNilUsesHelmValues: false |
|
By the way, the e2e testing has failed. |
SamYSF
force-pushed
the
add-service-monitor
branch
from
c499476
to
e54c0fb
Compare
SamYSF
force-pushed
the
add-service-monitor
branch
from
e54c0fb
to
768baec
Compare
|
LinuxSuRen
approved these changes
Jun 13, 2024
LinuxSuRen
pushed a commit
that referenced
this pull request
Jun 17, 2024
* chore(deps): update metabase/metabase docker tag to v0.47.4 * Update app version [skip ci] --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: github-action update-app-version <githubaction@githubaction.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #358
Create a serviceMonitor in the helm chart to expose the Promethus metrics.
