Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove apostrophes in comments to workaround ros2/launch_ros#214 #32

Merged
merged 1 commit into from Apr 20, 2021
Merged

Remove apostrophes in comments to workaround ros2/launch_ros#214 #32

merged 1 commit into from Apr 20, 2021

Conversation

oKermorgant
Copy link
Contributor

Hi,

As seen in ros2/launch_ros#214 and ros2/launch_ros/issues/136 launch files may have trouble getting the output of a xacro command if the parsed xacro files contain special YAML characters (typically apostrophes / colons inside comments).

The launch file examples of Plankton use the OpaqueFunction approach that explicitly runs xacro to generate a temporary URDF file. On the other hand, if the Command substitution is used (which is a common practice) then it fails on the current xacro files from Plankton.

This PR simply removes the apostrophes in the comments, following the same workaround as other people did.

@jpliquid
Copy link
Collaborator

Hi @oKermorgant,

I didn't know about apostrophes, but indeed I had noticed parsing errors due to colons inside comments (thank you for the related issues), which prevented me from using the Command substitution as you pointed out. Thanks for your contribution.

@jpliquid jpliquid merged commit 7539fbf into Liquid-ai:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants