-
Notifications
You must be signed in to change notification settings - Fork 4
Add RocksDB create checkpoint interface - Closes #54 #59
Conversation
Commit SHA:a2048e6d5604c6ae7e141829f92e58921cb2f017 Test coverage results 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally Looks good to me.
Please also update types.d.ts
for Database and StateDB to include
checkpoint(path: string): Promise<void>;
4a82b21
to
0adfcb2
Compare
Commit SHA:756d188dabeb3ff72ab24a580e7bca6629867a8e Test coverage results 🧪
|
Commit SHA:e8b10076d12626733c29a2abef13edac8eca3c48 Test coverage results 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase with the branch 38_refactor_for_OOP
because there are some conflicts and it will help you for my comment.
🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface 🌱 Add checkpoint interface
0adfcb2
to
8872647
Compare
Commit SHA:3c0f8f0dca756f3a2e8628793e6a8bfb703376f4 Test coverage results 🧪
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
What was the problem?
This PR resolves #54
How was it solved?
Function for creating RocksDB checkpoint for
Database
andStateDB
is exposed to JS library and it is possible to call it from JS code.How was it tested?