Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add RocksDB create checkpoint interface - Closes #54 #59

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

matjazv
Copy link
Contributor

@matjazv matjazv commented Sep 27, 2022

What was the problem?

This PR resolves #54

How was it solved?

Function for creating RocksDB checkpoint for Database and StateDB is exposed to JS library and it is possible to call it from JS code.

How was it tested?

  • some new tests were implemented
  • all tests passed

@matjazv matjazv self-assigned this Sep 27, 2022
@github-actions
Copy link

Commit SHA:a2048e6d5604c6ae7e141829f92e58921cb2f017

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 54_checkpoint_interface 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 74.11 (0.78) 59.06 (1.13) 78.72 (0.95) 73.96 (0.79)
🟢 database.js 76.03 (1.03) 57.14 (1.83) 80 (0.97) 76.03 (1.03)
🟢 state_db.js 68.9 (0.98) 57.31 (1.06) 70.68 (1.59) 68.9 (0.98)

Copy link
Collaborator

@shuse2 shuse2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally Looks good to me.
Please also update types.d.ts for Database and StateDB to include

checkpoint(path: string): Promise<void>;

test/database.spec.js Outdated Show resolved Hide resolved
@github-actions
Copy link

Commit SHA:756d188dabeb3ff72ab24a580e7bca6629867a8e

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 54_checkpoint_interface 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 74.11 (0.78) 59.06 (1.13) 78.72 (0.95) 73.96 (0.79)
🟢 database.js 76.03 (1.03) 57.14 (1.83) 80 (0.97) 76.03 (1.03)
🟢 state_db.js 68.9 (0.98) 57.31 (1.06) 70.68 (1.59) 68.9 (0.98)

@github-actions
Copy link

Commit SHA:e8b10076d12626733c29a2abef13edac8eca3c48

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 54_checkpoint_interface 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 74.11 (0.78) 59.06 (1.13) 78.72 (0.95) 73.96 (0.79)
🟢 database.js 76.03 (1.03) 57.14 (1.83) 80 (0.97) 76.03 (1.03)
🟢 state_db.js 68.9 (0.98) 57.31 (1.06) 70.68 (1.59) 68.9 (0.98)

Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase with the branch 38_refactor_for_OOP because there are some conflicts and it will help you for my comment.

src/db.rs Outdated Show resolved Hide resolved
🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface


🌱 Add checkpoint interface
@github-actions
Copy link

Commit SHA:3c0f8f0dca756f3a2e8628793e6a8bfb703376f4

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: 54_checkpoint_interface 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 74.11 (0.78) 59.06 (1.13) 78.72 (0.95) 73.96 (0.79)
🟢 database.js 76.03 (1.03) 57.14 (1.83) 80 (0.97) 76.03 (1.03)
🟢 state_db.js 68.9 (0.98) 57.31 (1.06) 70.68 (1.59) 68.9 (0.98)

Copy link
Contributor

@hrmhatef hrmhatef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@shuse2 shuse2 merged commit 80267cd into main Sep 28, 2022
@shuse2 shuse2 deleted the 54_checkpoint_interface branch September 28, 2022 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add checkpoint interface
3 participants