Skip to content
This repository has been archived by the owner on Jun 7, 2019. It is now read-only.

Update base transaction constructor to accept without id or signature #995

Closed
shuse2 opened this issue Jan 10, 2019 · 0 comments
Closed

Comments

@shuse2
Copy link
Contributor

shuse2 commented Jan 10, 2019

Expected behavior

When creating the transaction, id and signature does not exit before signing the transaction.
However, in order to call instance methods (ex: getBytes) when signing, constructor need to accept empty id and signature.

This should be checked on checkSchema.

Actual behavior

Rejected at the constructor if id or signature is empty

@shuse2 shuse2 self-assigned this Jan 10, 2019
@shuse2 shuse2 added this to Open Issues in Version 2.1.0 via automation Jan 10, 2019
shuse2 added a commit that referenced this issue Jan 10, 2019
Allow empty id and signature for constructor - Closes #995
@shuse2 shuse2 closed this as completed Jan 12, 2019
Version 2.1.0 automation moved this from Open Issues to Closed Issues Jan 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Version 2.1.0
  
Done
Development

No branches or pull requests

1 participant