This repository has been archived by the owner on Jun 7, 2019. It is now read-only.
Second signature registration transaction should update secondSignature flag for account - Closes #1147 #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuse2
reviewed
Feb 27, 2019
| @@ -209,6 +210,8 @@ export class SecondSignatureTransaction extends BaseTransaction { | |||
| protected undoAsset(store: StateStore): ReadonlyArray<TransactionError> { | |||
| const sender = store.account.get(this.senderId); | |||
| const { secondPublicKey, ...strippedSender } = sender; | |||
There was a problem hiding this comment.
Suggested change
| const { secondPublicKey, ...strippedSender } = sender; | |
| const { secondPublicKey, secondSignature, ...strippedSender } = sender; |
There was a problem hiding this comment.
@shuse2 I think we need the properties to be present for stateStore to handle them correctly so instead changed to de-structuring as we discussed.
SargeKhan
reviewed
Feb 27, 2019
| @@ -200,6 +200,7 @@ export class SecondSignatureTransaction extends BaseTransaction { | |||
| const updatedSender = { | |||
| ...sender, | |||
| secondPublicKey: this.asset.signature.publicKey, | |||
| secondSignature: true, | |||
There was a problem hiding this comment.
It should be a number, with values either 0 or 1.
shuse2
previously approved these changes
Feb 28, 2019
SargeKhan
reviewed
Feb 28, 2019
| const { secondPublicKey, ...strippedSender } = sender; | ||
| const strippedSender = { | ||
| ...sender, | ||
| secondPublicKey: undefined, |
There was a problem hiding this comment.
In Lisk-core, on undo action, the secondPublicKey property is assigned with the value null. Therefore, I think we should keep it consistent.
There was a problem hiding this comment.
@SargeKhan We have a TS lint rule that forbids null and favours undefined should I skip it in this case?
There was a problem hiding this comment.
Yeah, I guess we have to do it in this particular case.
SargeKhan
approved these changes
Feb 28, 2019
…transaction-should-update-secondsignature-flag-for-account
shuse2
approved these changes
Feb 28, 2019
shuse2
deleted the
1147-second-signature-registration-transaction-should-update-secondsignature-flag-for-account
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
How did I fix it?
How to test it?
Build should be green
Review checklist